fix(editor): NetworkPrefabProcessor not marking prefab list dirty #3102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetworkPrefabProcessor now marks the default NetworkPrefabsList ScriptableObject asset as dirty if there are new imports OR deletions. Unity is now aware of the changes and is able to write them to disk.
|
|
NoelStephensUnity
merged commit 1532417
into
Unity-Technologies:develop
2 checks passed
Collaborator
|
Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetworkPrefabProcessornow marks the defaultNetworkPrefabsListScriptableObjectasset as dirty if there are new imports OR deletions.The Unity Editor is now aware of the changes and able to write them to disk. This prevents the changes from being lost when the editor is quit and allows them to be tracked in version control.
Previously the script would only mark the list as dirty if there had been both new imports and deletions.
Changelog
NetworkPrefabProcessorwould not mark the prefab list as dirty and prevent saving theDefaultNetworkPrefabsasset when only imports or only deletes were detected.Testing and Documentation